I look at method_missing as a last resort as it ends up being less declarative and harder to read. Though, again, you end up dancing over lines when bending the language around like this, my goal is just to mitigate the weirdness. Also, I think using symbols is sort of representative of what were doing, comparing an immutable column with data in it to some value.

Fork the code and implement it, I would love to see exactly what you mean.

Truly it was, and it forced me to think my way around the language constraints however minor!

@AkitaOnRails

Sorry to say there isn’t. In a lot of cases you can use :foo.in to replace an OR statement but that won’t work all the time. An inner OR block perhaps? If you get to hacking on this send me a message on github and we can talk about merging!

Even if you do prefer their approach, ultimately it sounds like it was fun (and probably educational) to build your implementation!

Its a good thing I didn’t find that before I got started otherwise I probably wouldn’t have built this! I’ll have to take a look at the source and see if I like their implementation more than my own.

Spot on. Best case is that the where method, both in rails and the later more general implementation wouldn’t need to be touched by anyone. How often do people dive into ActiveRecord to tool around right? Still it’s a tradeoff and mutex’s are best avoided where possible. At least here it’s just some simple string and array operations.

Either way, this was the biggest faux pas that I perpetrated in making it a nice clean dsl, next on the list would be messing with Symbol.

Thanks for posting your thoughts.

Gotcha. I took a looksie at the code. The only part I don’t like is the mutex around the block execution. I understand why you did it, and there’s really no way to avoid it without giving up your symbol-based API in favor of, say, passing in an object which receives the operations… but I can see some n00blin’ doing something expensive or slow within the block, effecting other threads also building queries. I would maybe add a warning to the docs/readme warning about the mutex, and encouraging them not to do anything crazy within the block if running a multithreaded program.

Most likely the gists, I really need to get some syntax highlighting thats built into the blog.